search

Jaded-Encoding-Thaumaturgy / vs-denoise

VapourSynth denoising, regression, and motion compensation functions
MIT License
18 stars 6 forks source link

Adjust refine and sad mode values to match MVTools defaults. #89

Closed adworacz closed 1 year ago

adworacz commented 1 year ago

Noticed these changes when I was walking through the code earlier.

The previous values might surprise users, since they significantly differ from the MVTools defaults and can lead to a sizeable impact on out of the box performance.

Obviously, open for feedback on this one. I felt like the defaults shouldn't be a surprise to users, at least when compared to other usages of MVtools.

Setsugennoao commented 1 year ago

After thinking about it and confronting with others in the IEW Discord Server (which you should join, please!) I think it's best to leave these defaults since I personally think are better looking, and also because now a lot of scripts use this so they'll have worse results by updating and rerunning them.

adworacz commented 1 year ago

Totally fair, glad it was discussed/thought about. :)

I think it's worth explicitly documenting the differences in the defaults, just to prevent surprise by other consumers at the very least.

I can add that to my todo list.

And thanks for the invite to IEW, haha. I've been holding off due to lack of time/disliking Discord's walled garden (I'm still an old school Doom9'er, I admit :P), but I recognize that there's a lot of utility given how much discussion goes on there.