Previewing video results in completely wrong output

Jaded-Encoding-Thaumaturgy / vs-preview

Previewer for VapourSynth scripts.

Apache License 2.0

57 stars 16 forks source link

Previewing video results in completely wrong output #115

Closed ghost closed 9 months ago

ghost commented 9 months ago

vspreview currently ignores clip frame props entirely, along with the heuristic check being seemingly nonfunctional, instead always assuming BT709 left-aligned chroma for everything. This obviously results in completely wrong output for a massive amount of sources.

YomikoR commented 9 months ago

Steps to reproduce?

NSQY commented 9 months ago

chromaloc issue seems to be valid, TOP_LEFT should be assumed for UHD.

ghost commented 9 months ago

Steps to reproduce?

Just preview anything that is not BT.709 left chroma (i.e. 4K video)

ghost commented 9 months ago

In addition to the above, even if the heuristic check did work, it is not robust enough and will fail on anything that is 4:3.