Jaded-Encoding-Thaumaturgy / vs-preview

Previewer for VapourSynth scripts.
Apache License 2.0
61 stars 19 forks source link

Warn user if colourspace has to be assumed #139

Closed LightArrowsEXE closed 5 months ago

LightArrowsEXE commented 6 months ago

If any of the colourspace options (matrix/transfer/primaries) are set to 2, vspreview should warn the user that it has to assume the colourspace. This should imo display an error messages as such:

For example, 720x480 video:

WARN: The colorspace is unknown (2/2/2)! Assuming 6/6/6!

There are probably better ways to phrase this, but I want to get the following ideas across:

As an extension, this should maybe also be included in vstools.initialize_clip, if only for transparency's sake. Maybe even make it a part of the function that tries to guess a colourspace based on heuristics (behind a strict param)?

Setsugennoao commented 5 months ago

I don't like the idea of logging that. What about integrating it in the props tab.

Vodes commented 5 months ago

As it stands currently, the side menu is still entirely undiscoverable and having a log output would be immediately noticed

ghost commented 5 months ago

+1 for warning