Add customizable shortcuts settings - Githubissues

Jaded-Encoding-Thaumaturgy / vs-preview

Previewer for VapourSynth scripts.

Apache License 2.0

63 stars 19 forks source link

Add customizable shortcuts settings #180

Open Ichunjo opened 2 months ago

Ichunjo commented 2 months ago

Draft until I implement the existing hardcoded shortcuts. Feel free to give feedback if better approach or fixes.

Ichunjo commented 2 months ago

Should be ready to review.

Some key points:

Do you want me to make separate PRs for the random bugs I fixed (https://github.com/Jaded-Encoding-Thaumaturgy/vs-preview/pull/180/commits/884e0ba8d11c1d3391ec4ac510f77f326e0631af, https://github.com/Jaded-Encoding-Thaumaturgy/vs-preview/pull/180/commits/84770400cccd68d47fbbd82a988dc99e0fe8a558, https://github.com/Jaded-Encoding-Thaumaturgy/vs-preview/pull/180/commits/7af04107954363533ec454d1f29be2d784d5918c & https://github.com/Jaded-Encoding-Thaumaturgy/vs-preview/pull/180/commits/29a5776f245325aca0ca70a720a97d5d369fa78f, 6c8ec90
Plugins are lazily loaded but we need to make a partial load to get the shortcuts. API is slightly different but still compatible with current API
eval is used because some plugins need to be fully loaded to get the shortcuts working
Documentation is not updated :)

Setsugennoao commented 3 weeks ago

Can this be reviewed?

Ichunjo commented 3 weeks ago

yes