search

Jaded-Encoding-Thaumaturgy / vs-preview

Previewer for VapourSynth scripts.
Apache License 2.0
63 stars 19 forks source link

Update outputs combobox #212

Open Ichunjo opened 4 weeks ago

Ichunjo commented 4 weeks ago

This PR makes the line edit of the ouputs combo boxes as read only to prevent the user to write in it while still allowing them to select the text. Additionally, the line edit is now displaying the index number of the outputs.

Setsugennoao commented 3 weeks ago

Why would you not want it to be writeable?

Ichunjo commented 3 weeks ago

Why would you want to be writeable instead? You can't add new outputs by typing them so it doesn't really make sense to have it writeable. Plus if it's writeable like it is currently you have to click the small arrow to get the drop-down menu. With this change you can click anywhere on the combobox to open it.

Vodes commented 3 weeks ago

It's editable so you can change the node names before making a comp if need be

Setsugennoao commented 3 weeks ago

I also don't like it displaying the index

Ichunjo commented 3 weeks ago

It's editable so you can change the node names before making a comp if need be

If that’s the only reason, I’d suggest making this feature in the comp plugin itself then.

I also don't like it displaying the index

Any reason why? set_output now allows choosing the index number, it would make sense to display the vs index as well.