Jaded-Encoding-Thaumaturgy / vs-preview

Previewer for VapourSynth scripts.
Apache License 2.0
61 stars 19 forks source link

Scene Tool Crashing #62

Closed Jumaron closed 1 year ago

Jumaron commented 1 year ago

Hello when i tried to use it it crashes with two crashes.

CRASH: Traceback (most recent call last):
  File "C:\Program Files\Python310\lib\site-packages\vspreview\toolbars\scening\dialog.py", line 150, in on_label_changed
    index = self.tableview.selectionModel().selectedRows()[0]
IndexError: list index out of range

NEW CRASH:

Traceback (most recent call last):
  File "C:\Program Files\Python310\lib\site-packages\vspreview\main\timeline.py", line 272, in mouseMoveEvent
    QToolTip.showText(event.globalPosition(), notch.label)
TypeError: showText(QPoint, str, widget: QWidget = None, rect: QRect = {}, msecShowTime: int = -1): argument 1 has unexpected type 'QPointF' 
JustinTArthur commented 1 year ago

The first stacktrace looks to be from trying to set scene properties from the scene list without selecting a scene. Ultimately we should disable those controls until a scene is selected, but I've added code to ignore those controls sans-selection as a quick fix alongside the mouse-hover crash in PR Irrational-Encoding-Wizardry/vs-preview#65.