JadedCtrl / Cardie

Renamed to https://github.com/JadedCtrl/Chat-O-Matic
https://github.com/JadedCtrl/Chat-O-Matic
Other
2 stars 0 forks source link

Update/Replace RunView #47

Open JadedCtrl opened 3 years ago

JadedCtrl commented 3 years ago

RunView was initially borrowed from Vision― some improvements should probably be taken from modern Vision.

If features for our use-case can be implemented simpler with a fresh start (in short: multi-color text, emotes, URL recognition, right-click menu), that might be better, since RunView has some unnecessary flexibility (like theme support) that isn't the easiest to work around. This would hopefully help lower the line-count.

JadedCtrl commented 3 years ago

As of e6bb067, a new RunView has been written from scratch with near feature-pairity to the old (at least for the features that were actually used by Cardie): Easy appending of coloured text, URL highlighting/selecting, special right-click menu (including options for looking up the selected text), among some slight behaviour quirks (like Vision's RunView selecting hovered word on right-click, if nothing is selected).

It's a fair bit smaller, too (mainly because unused features were pruned): 736 LoC, compared to 4008.

The main feature that's missing is emote support/generally embedding BBitmaps.