search

JadenGeller / similarity-topology

Efficient nearest neighbor search in Swift
MIT License
5 stars 1 forks source link

MersenneTwister #1

Open JimWallace opened 10 months ago

JimWallace commented 10 months ago

Thanks for this repo - I'm playing around with it and would like for it to compile on both Darwin and Linux platforms, and I think the only barrier to that right now is that DeterministicRandomNumberGenerator relies on GameplayKit. Would you have any concerns with using a different library? My Google search finds a few options, e.g., https://github.com/quells/Squall.

I think the biggest downside is that these other libraries are not as stable as the ones Apple provides, but cross-platform compatibility would be a nice to have.

Thanks!

JadenGeller commented 8 months ago

Yeah, that seems worthwhile!

HNSWSample—the target that depends on GameplayKit—is only used by tests and HNSWVisualizer. HNSWAlgorithm should work fine across platforms, but it'd be nice to get tests working across platforms too.

I wouldn't mind using a different implementation, though I prefer to minimize use of 3rd-party dependencies. I see that Xoshiro is a popular and easy to implement PRNG, so I'll use an implementation of that.