search

JaeSeoKim / badge42

🚀 Dynamically generated 42 badge for your git readmes.
https://badge42.vercel.app
MIT License
435 stars 38 forks source link

Addition of certification procedures to satisfy the EU GDPR policy. #66

Closed JaeSeoKim closed 2 years ago

JaeSeoKim commented 2 years ago
GlaceCoding commented 2 years ago

We should not be able to see a card of user which not login a first time and give this consent, also the student can remove this consent at everytime :)

And privacyEmail / privacyName should be false by default and set true only by the concerned student.

GlaceCoding commented 2 years ago

Also if an user is BH can he login to remove this consent? but maybe he would like to keep this card or not 🤔

sanvit commented 2 years ago

@GlaceCoding afaik as long as the user isn't anonymized, the user should be able to receive their school domain email, so you can verify with that I guess. If the user gets anonymized, the API wouldn't be able to access their data anyways, so I think it won't be a problem

HamaBarhamou commented 2 years ago

What if the student is not 42?

JaeSeoKim commented 2 years ago

I’m sorry for the delay. There was a Covid issue in the middle, so I couldn’t develop it. Currently, along with the basic StatsBadge, 42, GitHub login and account deletion functions have been implemented. I would appreciate it if you could tell me what to improve along with the additional functions you need. https://badge42.vercel.app/ jaeskim’s stats badge: https://badge42.vercel.app/api/v2/stats/cl0yx1v0j0158ns5shlllmdvb?cursusId=21

JaeSeoKim commented 2 years ago

What if the student is not 42?

It is basically a service for 42 students, so it is not subject to service.

GlaceCoding commented 2 years ago

I’m sorry for the delay. There was a Covid issue in the middle, so I couldn’t develop it. Currently, along with the basic StatsBadge, 42, GitHub login and account deletion functions have been implemented. I would appreciate it if you could tell me what to improve along with the additional functions you need. https://badge42.vercel.app/ jaeskim’s stats badge: https://badge42.vercel.app/api/v2/stats/cl0yx1v0j0158ns5shlllmdvb?cursusId=21

Don't be sorry, your work is great !

I did some UI comment in the PR https://github.com/JaeSeoKim/badge42/pull/67#issuecomment-1073192751

dabel-co commented 2 years ago

I’m sorry for the delay. There was a Covid issue in the middle, so I couldn’t develop it. Currently, along with the basic StatsBadge, 42, GitHub login and account deletion functions have been implemented. I would appreciate it if you could tell me what to improve along with the additional functions you need. https://badge42.vercel.app/ jaeskim’s stats badge: https://badge42.vercel.app/api/v2/stats/cl0yx1v0j0158ns5shlllmdvb?cursusId=21

Having a way to display the score of certain projects ( the old [42Project Score] ) would be really neat. Thank you for making this GDPR friendly!