search

Jaeyoung-Lim / px4-offboard

Example of PX4 offboard control over microdds using python ROS 2
BSD 3-Clause "New" or "Revised" License
120 stars 52 forks source link

Updated README with new and detailed instructions on running the demo #4

Closed JohnTGZ closed 1 year ago

JohnTGZ commented 1 year ago

Removed a few instructions (especially those referring to a PR of the px4-autopilot branch as they have been merged into main). Added instruction to run micro-ros-agent in order to perform the mapping between the Micro XRCE-DDS and ROS2. This targets issue #3

mengchaoheng commented 1 year ago

You have overlooked many details, and the update you made is no different from the original one. What is the purpose of doing this? You make an unnecessary move. @JohnTGZ

Jaeyoung-Lim commented 1 year ago

@mengchaoheng I think the instruction @JohnTGZ has added was an improvement compared to the previous readme available.

If you think you can improve the readme better with the details that you think are missing, please create a PR

JohnTGZ commented 1 year ago

@mengchaoheng Thanks for the feedback. I'm sure the existing instructions available right now (and in the user guide) leaves much to be desired as the PX4 -ROS2 interface implementation is moving faster than the documentation. I found these particular set of instructions to work for me so I decided to do a quick PR, and I plan to make further improvements on further experimentation. Of course, if there are points of improvement, it would be a great help to everyone to make a PR.