search

JafarAkhondali / acer-predator-turbo-and-rgb-keyboard-linux-module

Linux kernel module to support Turbo mode and RGB Keyboard for Acer Predator notebook series
GNU General Public License v3.0
337 stars 59 forks source link

RGB, PT314-52s and turbo state fixes #125

Closed IllusionMan1212 closed 9 months ago

IllusionMan1212 commented 9 months ago

Getting the turbo LED state from WMI seems to be a miss on most (all?) models and this causes turbo to not be turned off. This PR aims to fix that by tracking the state in the driver itself.

This also fixes a typo in the PT314-52s model name which allows turbo and RGB to work.

This also writes 1 to byte 9 for the RGB keyboard for PT314-52s (and possibly other models) which allows both dynamic and static RGB lighting to work.

Maybe the RGB for 3 zone keyboards works now??

RGB might need to be tested for previously working models to make sure the write to byte 9 doesn't break anything

Should definitely fix these issues

110 (except for the turbo LED)

117

122 (Point 2)

Might possibly fix these RGB issues:

31

39

122 (Point 1)

JafarAkhondali commented 9 months ago

Thanks @IllusionMan1212 Do you mind sharing how did you find out to use byte 9 as well?

IllusionMan1212 commented 9 months ago

Thanks @IllusionMan1212 Do you mind sharing how did you find out to use byte 9 as well?

I called the WMI get method countless times on my PT314-52s and noticed it always has 1 in byte 9. Before the RGB never worked for me and with byte 9 as 1 it now works