search

JafarAkhondali / acer-predator-turbo-and-rgb-keyboard-linux-module

Linux kernel module to support Turbo mode and RGB Keyboard for Acer Predator notebook series
GNU General Public License v3.0
358 stars 66 forks source link

updated turbo-fan.service in PKGBUILD #58

Closed mmsaeed509 closed 2 years ago

JafarAkhondali commented 2 years ago

Hello. Can you modify the build somehow to rebuild Predator-Sense-systemd-git-1.0-1-any.pkg.tar.zst in builds instead storing it in the repo?

mmsaeed509 commented 2 years ago

Do you mean store all versions?

JafarAkhondali commented 2 years ago

I'm not familiar with arch package build system, but storing a built version of repository doesn't look like a good practice to me.
In other words, why do we have to keep a ~5mg file in the repo, when we have all the source code available?

mmsaeed509 commented 2 years ago

OK merge the pull request, then I'll remove the package and upload it to AUR Repository

mmsaeed509 commented 2 years ago

I'll close this pull request, as I submitted the changes on my forked repo (removed pkg), then I'll create a new pull request