search

JafarAkhondali / acer-predator-turbo-and-rgb-keyboard-linux-module

Linux kernel module to support Turbo mode and RGB Keyboard for Acer Predator notebook series
GNU General Public License v3.0
342 stars 59 forks source link

PyQt5 GUI #71

Closed saeedkhatami closed 1 year ago

saeedkhatami commented 1 year ago

Hi I've created the GUI for your project that helps the user to sets the color or mode or speed and etc... and this is my simple gui AKL

sorry for my English I'm from Iran and use google translate

JafarAkhondali commented 1 year ago

Salam Saeed Jan, Thanks for the GUI! Actually right now there are 3 GUIs for this project (including yours).
One made by Zehra, https://github.com/zehratullayl/Linux-Predator-GUI built with Js\Electron
One made by x21132, https://github.com/x211321/RGB-Config-Acer-gkbbl-0 built with PyQt

As I couldn't decide which to merge into main project, my personal idea was to keep GUIs in separate projects (e.g. in your Github personal page), and there you can use git sub-modules automatically to keep your project updated as the one here.
It's also possible to link the your project in Readme, so people can use your GUI if they like too. What do you think about this idea? It also allows other developers to clone the main project freely.

Also a suggestion for your code: only allow running the project if user have root access, or ask to promoted to root in GUI. Because if the user didn't use sudo recently in the terminal running the GUI, he won't be notified about asking for sudo promotion in the terminal.

saeedkhatami commented 1 year ago

oh thank you, I wrote this code for myself and for my system I was able to change the keyboard colors only with root access Thank you very much for your reply