search

Jaffa / amazon-music

Provide programmatic access to Amazon Music/Prime Music's streaming service
Apache License 2.0
342 stars 69 forks source link

Drop python2 support #7

Closed danieldaeschle closed 6 years ago

danieldaeschle commented 6 years ago

Just because python2 isn't relevant anymore...

Jaffa commented 6 years ago

It's not supposed to be relevant, but it's not a massive overhead to support at the moment (although the new new style .format strings are probably not supported on Python 2?) and I still come across environments and distributions that default to Python 2, treating Python 3 as a second class citizen :-(

danieldaeschle commented 6 years ago

Okay, still on python2 as default? Haha Python 3 is etablished very often now. Most of the big libraries has started to drop Python 2 support.

format example:

# Python 2
"%s" % my_str

# Python 2 & 3
"{0}".format(my_str)  # or
"{my_str}".format(my_str="my_str")

# Python 3.6 only
my_str = "my_str"
f"{my_str}"

I would recommend to use .format()

Jaffa commented 5 years ago

Marked as wontfix, but - at some point - we will.