search

Jaffe- / NESizer2

A synthesizer based on the 2A03 (NES APU)
103 stars 18 forks source link

Handle NoteOn,Vel=0 same as NoteOff #12

Closed beau-seidon closed 1 year ago

beau-seidon commented 1 year ago

Updated MIDI input code to comply with MIDI specification regarding stopping playback of notes. A NoteOn command with Velocity = 0 should be treated identically to NoteOff.

Jaffe- commented 1 year ago

Thanks for the pull request!

The commit dd0c5ff is enough to fix the issue. The other two commits introduce a new midi_note_vel member to struct getvalue, but it is not used for anything. So before getting this in, please remove the two commits adding midi_note_vel to struct getvalue and also remove the assignment of this in the remaining commit.

We can reintroduce this member later if it is actually going to be used :)

beau-seidon commented 1 year ago

well i tried to re-commit it cleanly based on some threads i found on StackExchange... and i bungled it. but at least the source is fixed, so the controller should do what it needs to but not more.

I will try to learn more about how to use github before attempting any more pull requests or commits.

Jaffe- commented 1 year ago

Thanks for the update! There are several ways of going about it, but I often find it easiest to just fix it up locally and then do a git reset to remove all the previous (faulty) commits, and then making new ones. To update the PR just force-push the new commits. In this case one commit would be sufficient. I'll squash them and merge them.