search

JagandeepBrar / lunasea

Self-hosted software controller built using Flutter
https://www.lunasea.app
GNU General Public License v3.0
1.31k stars 64 forks source link

[Bug] SABnzbd's history item stage_log can be a string #289

Closed JagandeepBrar closed 1 year ago

JagandeepBrar commented 3 years ago

Sometimes a history entry from SABnzbd can have the stage_log value as an empty string, not a List of strings. In this scenario, it causes the entire history view to fail to load until that history entry is outside of the 200 item load range.

Should do type checks, if it is an empty string, mutate it to be a list of a single empty string.

JagandeepBrar commented 3 years ago

This will get fixed when SABnzbd's API is separated into its own package during its rework.

For now, and for how often it happens (a few times have been reported in the past year), I will just leave it as-is and do the type-checking in the separated package. This can easily be remedied by deleting the breaking history entry through the web GUI.

IrPgFKS0 commented 3 years ago

When is the API rework scheduled to happen?

JagandeepBrar commented 3 years ago

@IrPgFKS0 Radarr is currently being upgraded, the clients (SAB and NZBGet) will happen after that.

IrPgFKS0 commented 3 years ago

Ah ok, I thought you meant separation of the API client stream in LunaSea (so you can put in different conditional checks per API endpoint), thank you.

JagandeepBrar commented 3 years ago

@IrPgFKS0 The "upgrade" I mentioned will include exactly that.

IrPgFKS0 commented 3 years ago

Thank you for confirming, great app BTW!

JagandeepBrar commented 1 year ago

This has been resolved with the release of SABnzbd 3.7.1.