search

JagandeepBrar / lunasea

Self-hosted software controller built using Flutter
https://www.lunasea.app
GNU General Public License v3.0
1.28k stars 64 forks source link

[Bug] Notifications deeplinks error when the profile name changes. #729

Closed timrettop closed 1 year ago

timrettop commented 1 year ago

Describe the Bug While creating a new profile, I also renamed the existing profile that was named default to "Main". Since then, clicking on notifications takes me to the app with a message "Unknown Profile" ... "default" does not exist in LunaSea.

To Reproduce

  1. Setup user notification on a service, e.g. Sonarr without changing profile name ("default").
  2. Change profile name
  3. Wait for notification and click on it.

Expected Behaviour Changes to the profile name should be handled by the notification system.

Screenshots IMG_605E65C54C0C-1

Versions 10.2.2 (Edge) build hash c46924c

Additional context Changing the name back to default returns to expected behavior.

JigSawFr commented 1 year ago

Facing the same problem (iOS)

JagandeepBrar commented 1 year ago

Hi @timrettop, @JigSawFr, did you both go through the process of correctly setting the profile name in the webhook configuration?

In Sonarr's notification documentation for example, please click the "Username" tab to further understand what I mean.

If this does not resolve the issue, please re-open the issue but off my testing it seems to be working as expected.

timrettop commented 1 year ago

Yes thats right, that addresses my issue, thank you!

Maybe alternatively there should be a warning triggered if the default profile name is changed or a new profile is added to check the notification webhooks?