JagdeepSinghNUS / pe

0 stars 0 forks source link

Unclear and inconsistent parameter values for deleteGroup Command #3

Open JagdeepSinghNUS opened 4 days ago

JagdeepSinghNUS commented 4 days ago

In your user guide it shows that, and I quote, "deleteGroup delete the group given the specific GROUPNAME". As shown in the photo, it also shows the example of the user entering deleteGroup StudyGroup1, which is the whole group name. However, the issue here is that the command does not check for the exact full name, rather it just checks for any group that matches a specific input, which can be disastrous as shown in my example below.

I created two groups, the first being StudyGroup1 and second being TutionGroup1, then I entered: deleteGroup 1 Which ended up deleting one of the groups. The issue here is, for a command that deletes data, while yes, students are not deleted just the group, it could be disastrous to not first check whether the input is an exact match. Keep in mind this is a test case with just 1 or 2 students, imagine a whole class of 60 students getting deleted because a teacher typed 1 number rather than the whole thing. Not an ideal example of defensive programming, furthermore, it contradicts the user guide example as shown in the photo and displayed by your team with your instructions of using the words specific GROUPNAME.

Screenshot 2024-11-15 at 4.27.01 PM.png

deleteGroup 1 example:

Screenshot 2024-11-15 at 4.27.10 PM.png

StudyGroup1 getting deleted example:

Screenshot 2024-11-15 at 4.27.19 PM.png

nus-se-bot commented 1 day ago

Your response not required for this bug as the team has accepted the bug as it is.