search

Jagroop2001 / validify-string

https://www.npmjs.com/package/validify-string
5 stars 11 forks source link

Adding Functionality of checking is string contains only ascii characters #21

Closed JavidSumra closed 9 months ago

JavidSumra commented 9 months ago

By Making This PR I am Solving Issue #14 I am Contributing Under JWOC 2024

Jagroop2001 commented 9 months ago

Please remove linting and also add these methods in readme.md file in the same PR @JavidSumra

JavidSumra commented 9 months ago

Hey @Jagroop2001 why do we need to remove the linting?

Jagroop2001 commented 9 months ago

So that only that changes are merged that you have changed. Not other's otherwise it cause issues of merge conflict to others @JavidSumra

JavidSumra commented 9 months ago

Hey @Jagroop2001 Sir Check now?

JavidSumra commented 9 months ago

@Jagroop2001 Sir Check Now?

Jagroop2001 commented 9 months ago

I mean remove all the linting in src/utils/utilityFunctions.ts page. Just do one thing, copy code from master and add your's. Only your code changes must be visible .

I hope it's clear to your 😊

JavidSumra commented 9 months ago

Hello, @Jagroop2001, Sir, I've accomplished the same task.

JavidSumra commented 9 months ago

Hey @Jagroop2001 Sir Please Have a Look Now..