search

Jaguar-dart / client

Contains various packages for client side
46 stars 22 forks source link

Retrofit status code 2xx #32

Closed jaumard closed 6 years ago

jaumard commented 6 years ago

Currently retrofit take all status as error except 200, it should take between 200 < 300 as a good response. root cause is resty : https://github.com/Jaguar-dart/client/blob/master/resty/lib/src/jaguar_resty_base.dart#L387

tejainece commented 6 years ago

Hi,

I purposefully changed it in this commit: https://github.com/Jaguar-dart/client/commit/335fcd193cfb66e5a5b0fbaae686e33666a000b9

Do you want it changed back?

jaumard commented 6 years ago

Hi :)

Yes for me it was correct previously as say in the doc 2xx: These codes indicate success. The body section if present is the object returned by the request. It is a MIME format object. It is in MIME format, and may only be in text/plain, text/html or one fo the formats specified as acceptable in the request.

jaumard commented 6 years ago

@tejainece let me know when you revert and deploy this please :) Thanks

jaumard commented 6 years ago

fixed