Large static file issues

chstrong commented 5 years ago

The static files part of Jaguar seems to have an issue with larger files or maybe unsupported content types. When I try to load a picture, it works, but with a video it will take forever and then output the binary representation of the video as text.

For testing the behaviour it should suffice to:

Create a static files folder: server.staticFiles('/media/*', Directory('bin/data'));
Then put a video into the bin/data directory, for example an mp4 video with a larger file size.
Start the server and try to open the video over the URL.

See also comment in this video (user that has PDF with same issue): https://www.youtube.com/watch?v=-IP-mc48n-A&index=9&list=PLS78sux6nBcRR9EyR3sBQxRXXW4jac7TR

library upload_files.server;

import 'dart:io';
import 'package:jaguar/jaguar.dart';
import 'package:path/path.dart' as p;
import 'package:jaguar_cors/jaguar_cors.dart';
import 'package:image/image.dart';

main(List<String> args) async {
  final server = Jaguar(port: 8005);

  final corsOptions = const CorsOptions(
    allowAllOrigins: true,
    allowAllHeaders: true,
    allowAllMethods: true);

  // API
  server.group('/api')
    // Upload route
    ..post('/upload', (ctx) async {
      final Map<String, FormField> formData = await ctx.bodyAsFormData();
      BinaryFileFormField media = formData['media'];
      if(media.contentType.toString().startsWith("image")) {
        if(media is BinaryFileListFormField) {
          //BinaryFileListFormField media = formData['media'];
          media.values.forEach((f) async {
            await f.writeTo(p.join('/Users/chstrong/Development/Git/Places/places_upl/bin/data/', f.filename));
            Image image = decodeImage(new File('/Users/chstrong/Development/Git/Places/places_upl/bin/data/' + f.filename).readAsBytesSync());
            Image thumbnail = copyResize(image, 300);
            new File('/Users/chstrong/Development/Git/Places/places_upl/bin/data/thumb_' + f.filename).writeAsBytesSync(encodePng(thumbnail));
          });
        } else {
          await media.writeTo(p.join('/Users/chstrong/Development/Git/Places/places_upl/bin/data/', media.filename));
          Image image = decodeImage(new File('/Users/chstrong/Development/Git/Places/places_upl/bin/data/' + media.filename).readAsBytesSync());
          Image thumbnail = copyResize(image, 300);
          new File('/Users/chstrong/Development/Git/Places/places_upl/bin/data/thumb_' + media.filename).writeAsBytesSync(encodePng(thumbnail));
        }
      } else if(media.contentType.toString().startsWith("video")) {
        if(media is BinaryFileListFormField) {
          //BinaryFileListFormField media = formData['media'];
          media.values.forEach((f) async {
            await f.writeTo(p.join('/Users/chstrong/Development/Git/Places/places_upl/bin/data/', f.filename));
          });
        } else {
          await media.writeTo(p.join('/Users/chstrong/Development/Git/Places/places_upl/bin/data/', media.filename));
        }        
      } else {
        return HttpStatus.badRequest;
      }
      return HttpStatus.ok;
    }, before: [new Cors(corsOptions)])
    ..options('/upload', (ctx) async {
      return HttpStatus.ok;
    }, before: [new Cors(corsOptions)]);

  // Serve the uploaded media
  server.staticFiles('/media/*', Directory('bin/data'));

  server.log.onRecord.listen(print);

  await server.serve(logRequests: true);
}