Fix group advantage

[Forien]

Type of change

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Translation (updates existing localization strings or adds complete new language file)
• [ ] Release (administrative update for tagged release, eg, changelog, readme, manifest)
• [ ] Maintenance (updates to the repository, dependencies and other non-functional code management)

Checklist:

• [ ] I have run linting on my code to follow the follow the style of this project.
• [ ] I have commented my code, particularly in hard-to-understand areas.
• [x] My changes generate no new unhandled or unexpected warnings.
• [ ] My change requires an update to the documentation.
• [x] I can be reached on Discord by my handle: forien

Related Issue(s)

• Fixes #237
• Fixes #250

Description

Motivation and context

Checking Document.ownership[game.user.id] is unsafe, as it may (and will) return undefined for GM, if GM is not explicit Owner of a Document.

For example:

There are 2 users in the world:

1. GM with aDepqlKkeOa13DWo id
2. User with JYO5JplQ4zaynRJ4 id

There is an Actor with the following ownership structure:

ownership = {
    "default": 1,
    "JYO5JplQ4zaynRJ4": 3
}

Current way of checking ownership would return undefined for GM, even though GM is always an implicit Owner of any and every Document.

Which is why using Document.isOwner getter is superior, and in my opinion, the only proper way of checking the ownership for current user.

Why didn't it work?

Actors created by Players (for example using Chargen if they have permission) do not have GM as an explicit Owner. Similarly, Actors that can be created programatically may not have GM as explicit Owner neither.

Summary of changes

Replaced every occurrence of `.ownership[game.user.id]` with `.isOwner` ### How has this been tested?

Ran Opposed Tests, using "Group Advantage" ruleset with Actors created by User as Attackers.

Development / Testing Environment

• Foundry VTT: 11.315
• WFRP4e System: 7.1.4
• GM Toolkit: 7.0.0

Btw, I spend more time filing this form than making PR lol 😂