Jahaja / psdash

A linux system information web dashboard using psutils and flask
Creative Commons Zero v1.0 Universal
2.42k stars 326 forks source link

JSON Output #32

Open delanne opened 10 years ago

delanne commented 10 years ago

This commits adds 2 things:

I added the JSON output, because I plan to use psdash to monitor some hosts. Some python scripts will send HTTP requests to psdash. The data will be keept and plot (like mrtg). In order to not make several HTTP Requests to get the process info, I added http://:/process//all

coveralls commented 10 years ago

Coverage Status

Changes Unknown when pulling 6b81394c72e39df9b46d444d95aa008bd8573b3a on delanne:jsonOutput into \ on Jahaja:master**.

Jahaja commented 10 years ago

Hi, thanks for the PR. You know that I've recently added support for multiple nodes right? I guess you're looking to extend on the current functionality to be able to plot graphs using your own script or similar?

I'm still evaluating whether to continue using zerorpc (may be good performance and network-wise with a lot of nodes, but probably not really significant) or just switch to letting agents return json instead. If I do that, the return as json functionality will be added as a result.

This could be a good use-case for adding some kind of plugin support. Could you explain what you want to do?

Nevermind the failed build btw, there's currently a race condition when starting multiple instances of padash and registering one of them to the other in the unittests.

delanne commented 10 years ago

Yes, I noticed that you add support for multiple nodes, that's an interesting feature !

what I want to do is:

Jahaja commented 10 years ago

Alright, thanks.

If this is added I would likely add it as an additional endpoint rather than as a part of the process endpoint. Also, I'm not sure if the change to using a bitmask for checking section is really needed as there's currently no support for multiple sections anyways apart from the ALL_SECTIONS special case that could be moved to it's own endpoint.

delanne commented 10 years ago

I agree, it makes sense.

2014-08-28 9:43 GMT+02:00 Joakim Hamrén notifications@github.com:

Alright, thanks.

If this is added I would likely add it as an additional endpoint rather than as a part of the process endpoint. Also, I'm not sure if the change to using a bitmask for checking section is really needed as there's currently no support for multiple sections anyways apart from the ALL_SECTIONS special case that could be moved to it's own endpoint.

— Reply to this email directly or view it on GitHub https://github.com/Jahaja/psdash/pull/32#issuecomment-53683572.