search

Jahfry / Miscellaneous

Notes and stuff I'm posting publicly
Other
50 stars 7 forks source link

Hardcoded Path #1

Closed ProjectInitiative closed 2 years ago

ProjectInitiative commented 2 years ago

line 81 contains a hard coded path that does not exist on all systems.

I suggest either documenting changing this line upon setup, or adding "intelligent" path walking.

ProjectInitiative commented 2 years ago

Also, I believe that since this script is only relevant to the node it exists on (i.e. no live migration of GPU/PCI VMs to another node) you can just use "/etc/pve/qemu-server" as the base path instead.

Jahfry commented 2 years ago

Thank you! Fixed. Much appreciate the pointer to /etc/pve/qemu-server.