search

Jahia / bootstrap4

This is a Bootstrap 4 implementation of http://getbootstrap.com for Digital Experience Manager
MIT License
0 stars 4 forks source link

Jahia 73 #22

Closed cedfou closed 4 years ago

cedfou commented 4 years ago

Proposition to have separate HTML5 (drag&droppable) Jahia components (section, article, ...) to use in Jahia Studio. Organization:

definitions:

views:

GOAL: The main purpose is to allow designer to identify visually/directly these widely used element and to be able to make a direct drag&drop into their templates. other benefits: the name of the component in the Studio correspond to the HTML element dragged (ex: 'section', instead of 'layout&grid') with allow direct verification for designer.

REM: This code doesn't break the other way to add HTML5 component in this modules (through "layout&grid" component or grid/createSection jsp). This proposition could probably be rewrite to allow the same goals (see above) and replace (+ be compatible) with the createSection code in the grid.jsp page (to allow both access with same definitions beneath)...

pvollenweider commented 4 years ago

Hello @cedfou,

It looks like it's a duplicate of https://github.com/JahiaCommunity/html5 ? Why do you want to include this non Bootstrap related code in this module ?

Philippe

cedfou commented 4 years ago

Mmh, yes. it's because it didn't exist yet at that time ;-) It's probably better to manage it in a separate module (https://github.com/JahiaCommunity/html5). It's ok for new projects.

Maybe it could be great to make the same 'exposure' (as direct d&d components) for the embedded HTML5 elements in your Bootstrap module? But my implementation would not be of any help for that, it will be better to 'expose' the same previous definitions for retro-compatibility... I don't know precisely how to do, I just push this sample code to give you ideas (reusing the same tag as wrapper for all elements ;) REM: moreover, there is a bug with the 'area' tag in this code...

So, you can cancel this PR, I will continue in the html5 community module.