search

JaiWWW / JPDB-Export

Adds a button to export deck contents, plus some other minor changes (see readme for full details)
GNU General Public License v3.0
5 stars 2 forks source link

Script managers other than Tampermonkey may not work #7

Open Jamiewu2 opened 2 years ago

Jamiewu2 commented 2 years ago

Tried on both Chrome and Firefox. Seemed to hang for Chrome, for Firefox, caused an internal server error

JaiWWW commented 2 years ago

Hi Jamie, it's working for me on firefox and I haven't tested on chrome yet but I will when I get back home. What are your firefox and tampermonkey versions? And are you running the latest version of the script (1.1.6)?

asayake-b5 commented 1 year ago

Hello, if it helps, I had issues on firefox with violentmonkey, I don't think it's related to the browser, but rather the script manager.

When using it, the pages wouldn't scroll, and I'd get a promise out of scope error, and then I'd become unable to use the script (no matter if I rebooted, restarted firefox etc, thankfully I had a couple computers and vms to try), because the script thought it was already running. Then I used chrome + tamper after seeing this (I ran out of firefoxes to try with) and it worked flawlessly.

Maybe the script is somehow only able to work on tampermonkey? If so I think it should be mentioned in the README, just in case (even if that's not it it seems tampermonkey is more likely to succeed).

EDIT: oh yeah, also I think I saw errors about GM_ something, and seeing the @grant GM in the script head, I wonder if some script managers aren't allowing it, hence the discrepancy

novastar88 commented 1 year ago

Doesn't work for me as well.

Firefox Greasemonkey

UPDATE Scripts for jpdb doesn't work on Greasemonkey, everything works well on Tampermonkey.

JaiWWW commented 1 year ago

Hmm. So sorry I forgot to respond to your feedback @sdbversini by the way! Unfortunately I don't have the time (or experience, really) to figure out why it doesn't work on other script managers, but I'll put a note in the readme. Thanks both for your reports!

novastar88 commented 1 year ago

Since it working (and works very good!) I don't mind, but I wanted to let know for other users that this problem exists.