Change hook to complete ZP order

GoogleCodeExporter commented 8 years ago

We use 'order created successfully' type of hook to complete ZP order after 
M.'s order is created.

At this moment we use hook which is invoked in default type of checkout 
process. But payment methods may implement custom types of checkout process, so 
the hook is never invoked.

The task is to find basic 'order created successfully' hook which is invoked 
right after the code where order is created successfully.

Original issue reported on code.google.com by Anatoly....@gmail.com on 7 Feb 2012 at 5:11

GoogleCodeExporter commented 8 years ago

Original comment by ad...@zetaprints.com on 7 Feb 2012 at 7:57

Added labels: Priority-High, Unit-0.5
Removed labels: Priority-Low

GoogleCodeExporter commented 8 years ago

Diff: http://code.google.com/p/magento-w2p/source/detail?r=1889

Original comment by Anatoly....@gmail.com on 7 Feb 2012 at 8:06

Changed state: Finished

GoogleCodeExporter commented 8 years ago

Please, test it with PayPal Express Checkout method on latest alpha release.

Original comment by Anatoly....@gmail.com on 8 Feb 2012 at 5:42

Changed state: ToTest

GoogleCodeExporter commented 8 years ago

Tested on /magedev/
web_to_print_store_incl_theme   2.0.1.0alpha4 (alpha)

I'm not sure what's suppose to happen.

- I placed an order using the "Check / money order" method and the order status 
in M admin was "Pending". Same order status is "To Print" in w2p portal.

- Placed an order using the "PayPal Express Checkout" method. The order status 
in M admin was "Processing". Same order status is "To Print" in w2p portal.

Judging from this issue title...I thought the express PP method was suppose to 
result in a "Complete" status? Anyway, since I don't know, these are the 
results of the test. If it acts like you intended it to, mark Test OK.

Original comment by agur...@gmail.com on 9 Feb 2012 at 9:55

Changed state: Discuss

GoogleCodeExporter commented 8 years ago

Atanas, it says "PROCESSING" because there was no payment confirmation - the 
site is behind a firewall. We can retest with the site accepting incoming 
requests.

Anatoly, what's happening with the flag we wanted to put in for not moving 
orders into TO PRINT if they are not confirmed?

Original comment by ad...@zetaprints.com on 10 Feb 2012 at 2:25

GoogleCodeExporter commented 8 years ago

Original comment by ad...@zetaprints.com on 12 Feb 2012 at 9:56

Added labels: Unit-1
Removed labels: Unit-0.5

GoogleCodeExporter commented 8 years ago

Please, re-test with 2.0.1.0beta4 release.

Also, we need to test all PayPal payment methods. Ask me if you will have some 
problems in configuring them.

Original comment by Anatoly....@gmail.com on 12 Feb 2012 at 5:11

Changed state: ToTest

GoogleCodeExporter commented 8 years ago

Tested on /magedev/
web_to_print_store_incl_theme   2.0.1.0beta4 (beta)

Placed an order using the "PayPal Express Checkout" method. The order status in 
M admin was "Processing". Same order status is "To Print" in w2p portal.
This is same as before.

Max, lift that firewall, ok?
Nothing special on mageimage / magedev anyway.

Anatoly, explain to me what is suppose to happen and when. I'm having a hard 
time understanding what should result with what here. Tell me what behaviors 
you set regarding this.

Original comment by agur...@gmail.com on 13 Feb 2012 at 1:39

Changed state: Discuss

GoogleCodeExporter commented 8 years ago

That's a correct behaviour for "PayPal Express Checkout" method. It processes 
payments before last step in M. checkout. And sets M. order status to 
"Processing" if the payment is successful. And the method is not affected by 
firewall.

Original comment by Anatoly....@gmail.com on 14 Feb 2012 at 12:12

Changed state: ToTest

GoogleCodeExporter commented 8 years ago

Tested on /magedev/
web_to_print_store_incl_theme   2.0.1.0beta4 (beta)

Used PayPal Express checkout method.

The order is not even registered in Magento until the payment is processed. But 
the same order is registered at ZP end under "saved" status.

The order appears in Magento under "Processing" status after the payment is 
processed, the files are generated and is moved to "To Print" folder in ZP end.

Original comment by agur...@gmail.com on 15 Feb 2012 at 11:42

Changed state: TestOK

GoogleCodeExporter commented 8 years ago

I don't feel we covered all scenarios. Maybe, maybe not. Let's make a decision 
table and then re-test.

Original comment by ad...@zetaprints.com on 16 Feb 2012 at 3:46

Changed state: MoreWork
Added labels: Unit-1.5
Removed labels: Unit-1

GoogleCodeExporter commented 8 years ago

Decision table: PaypalPaymentMethods

Original comment by Anatoly....@gmail.com on 16 Feb 2012 at 12:44

Changed state: ToTest

GoogleCodeExporter commented 8 years ago

Hm... can't get past this error (express_err.png).

I only get it on this "Simple" Magento product:
http://d1.zetaprints.com/magedev/index.php/multiple-fields-in-one-text-frame.htm
l

Thought it might be caused by a mismatch in my default customer address and 
that "PayPal sandbox buyer" dummy address but doesn't look like it. I tried 
setting that sandbox one as the default address for my account - same result. 
Anyway, I get the err on "Add to cart" before I'm even asked about my addresses.

Original comment by agur...@gmail.com on 16 Feb 2012 at 5:53

Changed state: MoreWork

Attachments:

express_err.png

GoogleCodeExporter commented 8 years ago

The decision table was a bit incorrect. I made changes, but not 100% sure it is 
correct now. Double check?

PaypalPaymentMethods

Original comment by ad...@zetaprints.com on 16 Feb 2012 at 7:17

GoogleCodeExporter commented 8 years ago

Reply to @13

PayPal checks that postcode is valid and it must match address. That's why I 
gave an address for testing. The address I gave doesn't set anywhere, just for 
easier testing.

Original comment by Anatoly....@gmail.com on 17 Feb 2012 at 4:42

Changed state: ToTest

GoogleCodeExporter commented 8 years ago

Original comment by Anatoly....@gmail.com on 17 Feb 2012 at 4:43

Changed state: MoreWork

GoogleCodeExporter commented 8 years ago

I will check it myself

Original comment by Anatoly....@gmail.com on 17 Feb 2012 at 4:43

GoogleCodeExporter commented 8 years ago

Guys, we need to get it out today.

Original comment by ad...@zetaprints.com on 17 Feb 2012 at 6:13

GoogleCodeExporter commented 8 years ago

Atanas, how did you add product to the cart? By Add to cart button?

I tried to checkout the product as guest in a usual way and it worked OK

Original comment by Anatoly....@gmail.com on 17 Feb 2012 at 9:25

GoogleCodeExporter commented 8 years ago

Original comment by Anatoly....@gmail.com on 17 Feb 2012 at 1:19

Changed state: Discuss

GoogleCodeExporter commented 8 years ago

It worked fine this time. Don't know what was causing this.
Here are the testing results.

Original comment by agur...@gmail.com on 17 Feb 2012 at 2:13

Changed state: MoreWork

Attachments:

PP_checkout_test.png

GoogleCodeExporter commented 8 years ago

Atanas, we need replication instructions for this, urgently.

Original comment by ad...@zetaprints.com on 18 Feb 2012 at 7:05

GoogleCodeExporter commented 8 years ago

I found that you need to Invoice order wit virtual product to complete it. It 
will capture money on PayPal. It generates another transaction. Don't know 
about it, sorry.

Original comment by Anatoly....@gmail.com on 18 Feb 2012 at 8:59

Changed state: ToTest

GoogleCodeExporter commented 8 years ago

1. Express checkout - 2 line in the table (virtual products)
- Navigate to
d1.zetaprints.com/magedev/index.php/magentot-01/1pg-template.html
- Update preview and click the PayPal button right there on the product page 
(the one under M. native "Add to cart")
- Proceed with the payment
- Check order status in M. admin and in w2p portal side (use ZP link from M. 
admin)
- Instead of Completed | Deleted the statuses are Processing | To Print 
accordingly.
- The files are generated, though

2. Standard checkout - third row in the table Simple product
- Navigate to 
http://d1.zetaprints.com/magedev/index.php/magentot-01/multiple-fields-in-one-te
xt-frame.html
- Update preview and add to cart.
- In the "Payment information" step choose the first PayPal option - PayPal 
standard checkout
- Check order statuses in M. admin and ZP end. They should be Pending payment | 
Saved
- Proceed all the way with the payment. Last link should be "Return to 
Anatoly's test sore"
- Check order statuses. They remain the same as when the order was placed, not 
upgraded to Processing | To Print as the table says they should be.

3. Standard checkout - fourth row in the table - Virtual product
- Navigate to
http://d1.zetaprints.com/magedev/index.php/magentot-01/1pg-template.html
- Update preview and add to cart.
- In the "Payment information" step choose the first PayPal option - PayPal 
standard checkout
- Check order statuses in M. admin and ZP end. They should be Pending payment | 
Saved
- Proceed all the way with the payment. Last link should be "Return to 
Anatoly's test sore"
- Check order statuses. They remain the same as when the order was placed, not 
upgraded to Completed | deleted as the table says they should be. Also, files 
are not generated on their own.

Note.
Yes, I know about invoicing. That's how I tested the first row of the table all 
the way.

Original comment by agur...@gmail.com on 18 Feb 2012 at 9:06

GoogleCodeExporter commented 8 years ago

Hold on. No. This won't work. It's totally needless to invoice every virtual 
product to get paid/complete the transaction. Totally ridiculous. Any ways 
around it?

Original comment by ad...@zetaprints.com on 19 Feb 2012 at 12:51

GoogleCodeExporter commented 8 years ago

We need to test other PayPal methods

Original comment by Anatoly....@gmail.com on 19 Feb 2012 at 4:30

GoogleCodeExporter commented 8 years ago

Looks like it works. Fingers crossed.

Original comment by ad...@zetaprints.com on 19 Feb 2012 at 10:23

Changed state: TestOK

GoogleCodeExporter commented 8 years ago

How come it is Test OK?
I still get the same results, only difference is that the "Payments" table is 
changed so its second row is now identical to the testing results (Processing | 
To Print for Virtuals on Express PayPal).
But the "Standard checkout" scenario is same (for Virtual and Simple prods) as 
it was before and it differs from the table. If I'm to write a help post about 
this I need to understand it.
Max, a chat?

Original comment by agur...@gmail.com on 20 Feb 2012 at 9:41

GoogleCodeExporter commented 8 years ago

Original comment by agur...@gmail.com on 20 Feb 2012 at 11:44

Changed state: Docos
Added labels: Help-X

GoogleCodeExporter commented 8 years ago

Original comment by ad...@zetaprints.com on 7 Mar 2012 at 12:14

Added labels: Period-2012-02

GoogleCodeExporter commented 8 years ago

This was covered with
http://www.zetaprints.com/magentohelp/ignore-unpaid-web-to-print-orders/

Original comment by agur...@gmail.com on 27 Mar 2012 at 12:36

Added labels: Help-V
Removed labels: Help-X

GoogleCodeExporter commented 8 years ago

Original comment by ad...@zetaprints.com on 28 Mar 2012 at 1:06

Changed state: Done

JaimeChizavane / magento-w2p

Change hook to complete ZP order #744