Preview filename extraction and HTTPS

JaimeChizavane / magento-w2p

Automatically exported from code.google.com/p/magento-w2p

0 stars 0 forks source link

Preview filename extraction and HTTPS #776

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

We incorrectly extract filename of the preview after update preview action when 
HTTPS is enabled on product page.

And then we use such wrong previews to create order on ZP.

Original issue reported on code.google.com by Anatoly....@gmail.com on 21 Mar 2012 at 4:46

GoogleCodeExporter commented 8 years ago

Is it why we have such huge mismatch on previews ?
!@#$%^ awesome.

Original comment by ad...@zetaprints.com on 21 Mar 2012 at 5:00

Added labels: Unit-0.5

GoogleCodeExporter commented 8 years ago

Which mismatch?

Diff: http://code.google.com/p/magento-w2p/source/detail?r=1939

Original comment by Anatoly....@gmail.com on 21 Mar 2012 at 5:22

Changed state: Finished

GoogleCodeExporter commented 8 years ago

1037 preview mismatch errors logged by ZP just for today.

Original comment by ad...@zetaprints.com on 21 Mar 2012 at 5:53

GoogleCodeExporter commented 8 years ago

I don't think the issue is a reason. I made that regression while implementing 
https://code.google.com/p/magento-w2p/issues/detail?id=717

Original comment by Anatoly....@gmail.com on 21 Mar 2012 at 6:40

GoogleCodeExporter commented 8 years ago

We need to test it with HTTPS mode enabled, but we don't have any server with 
configured HTTPS.

I think it will be enough to test update preview and add to cart action on 
plain HTTP.
Because the code I changed is a general and doesn't depend on HTTP mode

Original comment by Anatoly....@gmail.com on 21 Mar 2012 at 1:18

Changed state: ToTest

GoogleCodeExporter commented 8 years ago

Why can't you install a self-issues SSL on d1?

Original comment by ad...@zetaprints.com on 22 Mar 2012 at 1:23

GoogleCodeExporter commented 8 years ago

/magedev/ is HTTPS enabled

Original comment by Anatoly....@gmail.com on 22 Mar 2012 at 6:37

GoogleCodeExporter commented 8 years ago

Tested on /magedev/
web_to_print_store_incl_theme   2.1.1.0beta1 (beta)

placed two orders each for a single page:
https://d1.zetaprints.com/magedev/index.php/magentot-01/1pg-template.html
and multipage templates:
https://d1.zetaprints.com/magedev/index.php/magentot-02/bussines-card-02.html

The output PDF correspond to the preview images I got in all of them.

Original comment by agur...@gmail.com on 22 Mar 2012 at 10:56

Changed state: TestOK

GoogleCodeExporter commented 8 years ago

does it work on http then?

Original comment by ad...@zetaprints.com on 22 Mar 2012 at 10:58

GoogleCodeExporter commented 8 years ago

I tried it on /mageimage/ (Magento ver. 1.6.1.0)
which has no httpS

Same testing procedure. Single page:
http://d1.zetaprints.com/mageimage/index.php/magentot-01/1pg-template.html
multipage:
http://d1.zetaprints.com/mageimage/index.php/magentot-02/bussines-card-02.html

Generated PDFs match the updated preview

Original comment by agur...@gmail.com on 22 Mar 2012 at 3:31

GoogleCodeExporter commented 8 years ago

Original comment by ad...@zetaprints.com on 3 Apr 2012 at 12:34

Changed state: Done
Added labels: Period-2012-03