Jajared / pe

0 stars 0 forks source link

Adding an appointment with the same time error message lacking details #3

Open Jajared opened 6 months ago

Jajared commented 6 months ago

Describe the bug When adding an appointment with the same time, the error message returned is 'This meeting already exists in the address book'. While it is mentioned in the UG that a unique meeting time must be provided, the error message is lacking details and does not explain much.

To Reproduce Steps to reproduce the behavior:

  1. Run any command to add a new appointment
  2. An appointment is successfully added
  3. Run a new command to add a new appointment (with a different name but same timing)
  4. An error message is returned

Expected behavior A more detailed error message can be provided for easier debugging. For example, the error message can provide more information such as 'A meeting with the same timing already exists in the address book'

Screenshots Screenshot 2024-04-19 at 4.22.08 PM.png

Additional context Nil

nus-pe-script commented 6 months ago

Team's Response

We believe that the current error message is good enough to point out the problem. We may improve the error message to be more descriptive in future versions.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The error message in question: The meeting already exists in the address book could have multiple meanings: Meeting with the same person? Meeting with the same timing? What constitutes a same meeting in this case? While it is clear that a meeting with the same timing cannot be added since it was stated in the UG, this level of detail is not reflected in the product.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]