Jajared / pe

0 stars 0 forks source link

Invalid input not handled correctly #5

Open Jajared opened 6 months ago

Jajared commented 6 months ago

Describe the bug The add command is not handled correctly when given the wrong input (specifically a partial input)

To Reproduce Steps to reproduce the behavior:

  1. Run the command 'add n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 m/2024-07-12 12:00 t'.
  2. An error message indicating invalid date appears

Expected behavior Screenshot 2024-04-19 at 4.58.48 PM.png

Originally i wanted to run the command 'add n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 m/2024-07-12 12:00 t/Friends'.

It is stated in the UG that any extra inputs in the command will not be regarded as part of the command. In this case, it seems like the extra 't' is regarded as part of the date and is thus throwing me a date format error. While this might seem very trivial, there may be instances where users may make a typo or may not complete their command input.

Screenshots Screenshot 2024-04-19 at 4.54.41 PM.png

Additional context Nil

nus-pe-script commented 6 months ago

Team's Response

That is not a command word but a parameter.

Command word for this case is "add" and the parameter needed is "t/"

Since you did not specify t/ at the end, the 't' is clearly included in the 'm/' field as a parameter. Hence the error message shown is correct.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]