Jajared / pe

0 stars 0 forks source link

Non-alphanumeric characters not allowed in tags #6

Open Jajared opened 6 months ago

Jajared commented 6 months ago

Describe the bug This is more of a question than issue. It seems that the decision to only allow for alphanumeric characters in tags can limit options for users. For example, tags should not be just limited to alphanumeric characters (single words in this case). Consider the case where the tag could be multiple words such as 'Best Friend'. However, this is not allowed because of the space which is not regarded as an alphanumeric character. This allowance is reflected in the policy name and thus can be extended to tags

To Reproduce Steps to reproduce the behavior:

  1. Run the command 'add n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 m/2024-07-12 12:00 t/Best Friend'.
  2. An error message indicating that tag names should be alphanumeric appears.

Expected behavior Depending on future implementations, non-alphanumeric characters may be allowed.

Screenshots Screenshot 2024-04-19 at 5.06.16 PM.png

Additional context Nil

nus-se-bot commented 6 months ago

Team's Response

For the current version, I think the functionality of tags is enough. However, we will look into this in the future.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]