Basic styling - Githubissues

JakeAdmire / Ghibli-Tracker

Explore your favorite films from Studio Ghibli!

https://jakeadmire.github.io/Ghibli-Tracker/

1 stars 0 forks source link

Basic styling #12

Closed JakeAdmire closed 5 years ago

JakeAdmire commented 5 years ago

Changes made:

Remove unnecessary h1 tags from multiple components
Add classNames to multiple components

App

Replace url to represent our custom movie data

CardContainer

Build grid for cards and define padding

Card

Remove img tag within Card component and replace with inline background image
Define Card size and border radius for basic styling

Header

Add flex to center text
Replace text to reflect project title
Define header as fixed positioning

Variables

Add mixins for customFont and flexBox

Before:

Screen Shot 2019-03-21 at 11 52 35 AM

After:

Screen Shot 2019-03-21 at 11 52 19 AM

kimmichurri commented 5 years ago

Thank you for bringing in the url for the movies we wanted to capture. I love the use of grid for the movie cards. Thank you for including the before and after of the UI.