Closed jeroenvisser101 closed 4 years ago
This project has moved!
It's now being maintained by proactive volunteers from the Elixir community over at elixir-lsp/elixir-ls. Updates will continue to be published from that repo to the original VS Code extension, so no need to switch plugins if you're using VS Code.
If you're still interested in merging this PR, please do the following:
Thank you!
When callbacks are marked with
@impl (true | mod)
their typespec/contract is inferred from the specified implementation.In this forum post @fishcakez mentions this:
Given a very generic behaviours such as GenServer where the type of the state is unknown, it might be better to introduce a custom spec, but in the case of less generic behaviours, inferring seems the right thing to do.
Anyway, very much debatable if this is the right thing to do, and after having implemented this change I'm less certain this is a good change. Can we discuss the pros/cons of this?