search

JakeBecker / elixir-ls

A frontend-independent IDE "smartness" server for Elixir. Implements the JSON-based "Language Server Protocol" standard and provides debugger support via VS Code's debugger protocol.
Apache License 2.0
843 stars 52 forks source link

Fix requestMessage doesnt seem to match spec #210

Closed bfolkens closed 4 years ago

bfolkens commented 4 years ago

In the LSP spec for requestMessage, the params key is optional. However, the code seems to only expect the 3 arity variant. This patch allows both the 2 arity and 3 arity variants, so that the shutdown requests will work (which doesn't include a params key).

Fixes #209

See also: https://microsoft.github.io/language-server-protocol/specifications/specification-current/#requestMessage

JakeBecker commented 4 years ago

This project has moved!

It's now being maintained by proactive volunteers from the Elixir community over at elixir-lsp/elixir-ls. Updates will continue to be published from that repo to the original VS Code extension, so no need to switch plugins if you're using VS Code.

If you're still interested in merging this PR, please do the following:

  1. Check that the issue you're addressing still occurs with the latest version of the VS Code plugin (which is published from the new repo)
  2. Check if there's an issue for it on the new repo, and create one if not
  3. Rebase your PR from the new repo (which has diverged significantly) and re-submit it there.

Thank you!