search

JakeBecker / vscode-elixir-ls

Elixir language support and debugger for VS Code, powered by ElixirLS.
391 stars 42 forks source link

Add function call syntax scope #147

Closed CaiqueMitsuoka closed 4 years ago

CaiqueMitsuoka commented 5 years ago

Add the pattern to scope the function calls with parenthesis or dot/parenthesis and for Module.function i.e. any non ambiguous function call. Allowing themes to change the color of them.

I've also added to Sublime and there you can find more of the reason behind it. TL;DR We as community avoid ambiguous calls with the compilation warning and the formatter, so we should support this approach .

I've been using for some weeks now and has been a great experience.

functions calls highlighted and 3 cases that it should not highlight
JakeBecker commented 4 years ago

This project has moved!

It's now being maintained by proactive volunteers from the Elixir community over at elixir-lsp/vscode-elixir-ls. The main ElixirLS codebase is now at elixir-lsp/elixir-ls. Updates will continue to be published from that repo to the original VS Code extension, so no need to switch plugins.

If you're still interested in merging this PR, please do the following:

  1. Check that the issue you're addressing still occurs with the latest version of the VS Code plugin (which is published from the new repo)
  2. If your PR references a Github issue, check if there's already an issue filed on the new repo and create one if not
  3. Rebase your PR from the new repo (which has diverged significantly) and re-submit it there.

Thank you!