search

JakeGinnivan / react-popout

React popout is a React component wrapping window.open allowing you to host content in a browser popup window.
MIT License
188 stars 59 forks source link

Popout without url property doesn't work after 1.0 release #39

Closed limpbrains closed 7 years ago

limpbrains commented 7 years ago

An empty page opens without any errors. If I add an URL - everything works

marchaos commented 7 years ago

Hi, let me test that and get back to you.

marchaos commented 7 years ago

Hi, I've fixed this issue. I've checked the demos which were broken, but should all be working now. I've published 1.0.1 which should fix this issue.

Let me know how that goes.

marchaos commented 7 years ago

See PR - https://github.com/JakeGinnivan/react-popout/pull/40

limpbrains commented 7 years ago

@marchaos fixed, thanks!