"Cannot navigate to invalid URL" when having special characters in the URL

JakePartusch / lumberjack

An automated website accessibility scanner and cli

https://github.com/JakePartusch/lumberjack

MIT License

126 stars 7 forks source link

"Cannot navigate to invalid URL" when having special characters in the URL #6

Closed ghost closed 4 years ago

ghost commented 4 years ago

When having umlauts or other special characters, lumberjack fails with the message:

Protocol error (Page.navigate): Cannot navigate to invalid URL

Steps to reproduce:

Invoke lumberjack --url https://velo.rent

JakePartusch commented 4 years ago

I think that the problem here is that the sitemap has relative URLs. With that being said, I'm not able to find a definitive source on whether or not relative URLs in a sitemap are valid or not... 🤷‍♂

If relative URLs are indeed a valid/common use-case, I definitely think we should support 👍

ghost commented 4 years ago

I actually don't know either, but the sitemap was generated by the default Hugo template, so I assume they are valid. :D

JakePartusch commented 4 years ago

Ok cool. @jlnostr, If you want to take a stab at a fix, that would be awesome! 🎉

Otherwise, I'll get around to it soon-ish