search

JakePartusch / wait-for-netlify-action

A GitHub action that will wait until a Netlify Preview deploy has completed before continuing on
MIT License
47 stars 52 forks source link

Have dynamic check path #15

Closed jawakarD closed 2 years ago

jawakarD commented 3 years ago

As of now, looks like the this action checks for the root path https://github.com/JakePartusch/wait-for-netlify-action/blob/d85a22dfa96b3f4537d8abdf2dab4ba2a6ac2079/index.js#L32 but some sites would not have the root path, but will have other pages. This will throw 404 when the action tries to access the non existing page and won't resolve to 200 at all.

Solution could be to accept a option check_path.

Would like to open a PR if it's fine.

JakePartusch commented 3 years ago

@jawakarD, sure go for it! I think that would be a fine enhancement.

Maybe it could be base_path which has a default of /?