search

JakePickle / teamform-seed

This project is an application skeleton. It is used for a HKUST Software Engineering Course (COMP3111/H) in Fall 2016/17. My goal: The project is not asking students to re-produce the sample project. We should encourage students to do something better than the TA.
https://course.cse.ust.hk/comp3111/teamform/
MIT License
0 stars 4 forks source link

Use versions of libraries specified by Peter #56

Closed suyanzhe closed 7 years ago

suyanzhe commented 7 years ago

The versions of libraries are already specified by Peter and provided in the original project structure. Especially, Firebase 2.2.4 is not okay for the project, version 3.x required. In project specification Firebase (v3.0.3) - It is NOT allowed to use the legacy Firebase (i.e. 2.x) API

suyanzhe commented 7 years ago

I am fixing the typos in the comment of #57 here.

suyanzhe commented 7 years ago

Please redo #54. The change to firebase version is compulsory.

Patric-Lee commented 7 years ago

As who did #54, I am sure I am using Firebase version 3.x.x. And the code is based on the tutorial on AngularFire website. I wonder the reason why you think legacy APIs are used. Have I mistakenly using some of them?

Patric-Lee commented 7 years ago

Okay. I am sorry about my mistake. The change would be applied soon.

Patric-Lee commented 7 years ago

I have fixed the version issue. In the forthcoming pull request it would be applied.

suyanzhe commented 7 years ago

Thank you very much. I am still waiting for the "forthcoming pull request"