search

JakeRoggenbuck / auto-clock-speed

A utility to check stats about your CPU, and auto regulate clock speeds to help with either performance or battery life.
https://autoclockspeed.org
MIT License
37 stars 9 forks source link

Add csv logging from daemon #432

Closed JakeRoggenbuck closed 2 years ago

JakeRoggenbuck commented 2 years ago

fixes #359

JakeRoggenbuck commented 2 years ago

image

JakeRoggenbuck commented 2 years ago

The only thing I have not written yet is the "die after 5mb" for log file size

JakeRoggenbuck commented 2 years ago

@Shuzhengz Should I create the file size check in this pr or not?

Shuzhengz commented 2 years ago

yeah i think it should be included in this pr, but we can also just make a new issue and deal with it later the main concern is causing system to crash when exceed max file size, but that's pretty unlikely in modern systems

JakeRoggenbuck commented 2 years ago

Yea, it's a very good thing to consider. I'll also check the permissions needed to create the csv file. I'll probably do it in this PR.

JakeRoggenbuck commented 2 years ago

Looks like i need all change requesters to review. Probably a good thing

JakeRoggenbuck commented 2 years ago

Cool, it has one review and I fixed all the requested changes, so i'm gonna merge it.