search

JakeSays / QtCreatorTerminalPlugin

Provides an embedded terminal/shell for Qt Creator
Other
20 stars 7 forks source link

Initial macOS port #6

Open mrexodia opened 1 year ago

mrexodia commented 1 year ago

image

These changes are just enough to make things compile (your last commit also broke the .json.in detection so I had to move that). Unfortunately it looks like backspace/delete is not working and neither are the arrows. I don't know anything about macOS though, so maybe someone else will come along and improve it. If you have suggestions on how to debug this I am also open to try it.

JakeSays commented 1 year ago

@mrexodia Hey I appreciate the PR, but I am going to hold off on merging it until I have the capacity to build/test locally.

mrexodia commented 1 year ago

Sure! Like I said, this doesn’t actually work but it at least fixes the build. I made sure these changes are only for macOS, on Linux everything should work the same.

I would encourage you to consider merging them anyway after you confirmed this doesn’t affect the Linux build. Otherwise things will probably desynchonize…

JakeSays commented 1 year ago

I am planning on doing a ton of cleanup to remove all of the KDE code that isn't actually being used, and then add a proper configuration dialog. I'll merge this in before doing that refactor.