search

JakeSidSmith / react-fastclick

Fast Touch Events for React
https://www.npmjs.com/package/react-fastclick
MIT License
487 stars 41 forks source link

React 0.14 support #16

Closed JakeSidSmith closed 8 years ago

JakeSidSmith commented 8 years ago

Add "react-fastclick": "git://github.com/jakesidsmith/react-fastclick.git#react-0.14-support" to your dependencies for testing.

JakeSidSmith commented 8 years ago

This seems to cause issues with input focussing & standard anchor links. Will need to take another look.

JakeSidSmith commented 8 years ago

Events triggered on tap (when not preventing default).

[Log] topTouchStart
[Log] Event: null // made it passed SyntheticUIEvent.getPooled
[Log] topTouchEnd
[Log] Event type: touchend // made it passed SyntheticUIEvent.getPooled
[Log] topMouseMove
[Log] topMouseDown
[Log] topMouseUp
[Log] topClick
[Log] topSelectionChange
naps62 commented 8 years ago

@JakeSidSmith I'm trying to use this branch without success Using react 0.14.3, and importing like this:

require('react-fastclick');
import React form 'react';

on a desktop computer, it runs fine (although there's way to test if fastclick is working, AFAIK) when opening the exact same page on my Android tablet, I get this error in the inspector:

Uncaught Error: Invariant Violation: EventPluginHub: More than one plugin attempted to publish the same event name, click.

Is this a known issue? Any workarounds at this point?

JakeSidSmith commented 8 years ago

That's weird. I hadn't experienced that. I'm still brainstorming a better way to handle 0.14, as this solution seems to have several issues.

I have a few ideas, just need to get some time to implement & test them.