search

JakeSidSmith / react-fastclick

Fast Touch Events for React
https://www.npmjs.com/package/react-fastclick
MIT License
487 stars 41 forks source link

Fix bleed to other elements #50

Closed JakeSidSmith closed 7 years ago

JakeSidSmith commented 7 years ago

I have published an alpha version 3.0.2-alpha.1 for testing before release.

If you could please try out this alpha version & let me know on this PR if it has fixed your issue (please provide issue number).

Fixes #29 Fixes #33

Possibly fixes #34 ? Possibly fixes #48 ?

nealoke commented 7 years ago

@JakeSidSmith I would like to test this but i'm to noob to figure out how to download this pull request. Is there a possibility to npm install this pull? Sorry for the lack of experience here :/

JakeSidSmith commented 7 years ago

Yup. It's on npm as 3.0.2-alpha.1. Just update the version in your package.json, clear from your node_modules and npm install. :)

nealoke commented 7 years ago

Great, I'll test this the either today or tomorrow, thanks!

nealoke commented 7 years ago

@JakeSidSmith so sorry for the late follow up.

I tested with the case provided from @gomo and that is definitly resolved. The only thing that is still happening (in my application) is that for whatever reason the click is being blocked but the keyboard still pops up. (I'm not sure that react-fastclick is the cause though.

Thanks and nice work @JakeSidSmith !

JakeSidSmith commented 7 years ago

@nealoke on mobile (Android or iOS)? You want to tap an input, but not have the keyboard open? Have you tried event.preventDefault() in the onClick? Or in onTouchStart?

nealoke commented 7 years ago

@JakeSidSmith I'm not sure what fixed it but I guess it had something to do with my popup styling (weird though). But can't seem to reproduce it anymore. So all good for me 👍 :)

I tested the test case of @gomo on both IOS and Android (via browserstack)

JakeSidSmith commented 7 years ago

Guess I'll release this and see how it goes then. :)

zhengzhiqiang commented 6 years ago

problem

@JakeSidSmith When I use version 3.0.1, it will bleed to another element, so I upgrade to 3.0.2, then I find another problem: when I click an input element, the input will blur.

It happens on iphone devices, 6ps happened always.