search

JakeSidSmith / react-fastclick

Fast Touch Events for React
https://www.npmjs.com/package/react-fastclick
MIT License
487 stars 41 forks source link

Add the ability to disable fastclick #55

Closed nickhingston closed 1 year ago

nickhingston commented 6 years ago

Add no-fastclick css class to an element, and the fastclick input event handlers will be no longer applied

fixes #54.

JakeSidSmith commented 6 years ago

I would prefer if this could use data attributes as it's less likely to have side effects, and just because I feel that classNames are "supposed" to be CSS selectors, mainly.

https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes

nickhingston commented 6 years ago

I chose to do it like this cos thats how the popular https://github.com/ftlabs/fastclick https://github.com/ftlabs/fastclick does it…

didn't like the “needsclick” name tho!

but its your repo :)

On 9 Oct 2017, at 10:01, Jake notifications@github.com wrote:

I would prefer if this could use data attributes as it's less likely to have side effects, and just because I feel that classNames are "supposed" to be CSS selectors, mainly.

https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JakeSidSmith/react-fastclick/pull/55#issuecomment-335100966, or mute the thread https://github.com/notifications/unsubscribe-auth/AA059Xs16WOhtkgZg99gyu9qGF01QPoOks5sqeDygaJpZM4PyJwQ.