search

JakeSidSmith / react-reorder

Drag & drop, touch enabled, reorderable / sortable list, React component
https://jakesidsmith.github.io/react-reorder/
MIT License
218 stars 58 forks source link

Create class warning (fix) #80

Closed JakeSidSmith closed 7 years ago

JakeSidSmith commented 7 years ago

Fixes #79

romamatusevich commented 7 years ago

The changes look fine. I don't think this pull request needs some changes in gitignore, but it's not an issue.

/coverage/**
.nyc_output/*

Tested building and examples locally. Also the result is fine without react 15.5.0 warning.

JakeSidSmith commented 7 years ago

@romamatusevich since adding coverage to the v3 alpha, I figured it was easier for me to update the gitignore in v2 than to keep deleting all the output files. Shouldn't have any impact on the lib itself. :)

JakeSidSmith commented 7 years ago

If you're happy I'll merge and release it now.

romamatusevich commented 7 years ago

Thank you!

wmertens commented 7 years ago

Why not simply convert it to a ES6 class instead of using that create-class library? Is there some blocking dependency?

JakeSidSmith commented 7 years ago

ES6 classes work pretty differently, e.g. not binding methods. This was the quickest way to get a fix out. Otherwise I'd not only have to re-write the component, but setup all the build / dist stuff to work with ES6. Will likely be rewriting in TypeScript in the near future.

wmertens commented 7 years ago

Aha makes sense :+1: