search

JakeStanger / ironbar

Customisable Wayland gtk bar written in Rust.
https://crates.io/crates/ironbar
MIT License
487 stars 36 forks source link

Dialog Menus show up in launcher #606

Open ClaireNeveu opened 1 month ago

ClaireNeveu commented 1 month ago

Describe the bug Sub-windows in an application (like dialog menus) appear in the launcher when open.

To Reproduce Steps to reproduce the behavior:

  1. Open VS Code
  2. Right click in the file editor
  3. Observe that a new item appears in the launcher

Expected behavior The launcher should not display a new item.

System information:

Configuration

Share your bar configuration and stylesheet as applicable:

Config ``` ```
Styles ```css ```

Additional context This might be related to Krita getting stuck in the launcher since it opens a lot of subwindows.

Screenshots

If applicable, add screenshots to help explain your problem.

ClaireNeveu commented 1 month ago

Still working on getting a minimum repro on the Krita issue, it doesn't happen if you close Krita right away but consistently after I've been drawing for an hour or two and close it, ironbar thinks it's still running until I restart ironbar.

JakeStanger commented 1 month ago

I've got a feeling this is going to be an easy fix, or nigh impossible. Out of interest, do you know whether krita is native or xwayland?

ClaireNeveu commented 1 month ago

Krita is an xwayland app.

JakeStanger commented 1 month ago

In theory, I think it should be possible to detect if a window has a parent window using wlr_foreign_toplevel_management, which is already hooked up. This means it should be easy.

As far as I can see though, Hyprland never sends that info, so I need to dig a bit deeper and see if another compositor does and if it'll help.

As an aside, I had krita open to test and hit the same bug where it doesn't close properly. I did open a single dialog. It seems strange I've never seen this occur with anything else. My Jetbrains IDEs are all xwayland and spam child windows like nothing else so I don't think that's the culprit.

ClaireNeveu commented 1 month ago

Hmm, this might be a bug in Hyprland, they just did a big rewrite with 0.40.0.

JakeStanger commented 3 weeks ago

...and an even bigger one with 0.41.0. Hyprland isn't particularly stable right now as a result, but I'd be interested to know if you still have the issue after updating.

ClaireNeveu commented 3 weeks ago

This does still happen on 0.41.x

ClaireNeveu commented 3 weeks ago

0.41.x is even more broken than 0.40.x it seems so take that for what it is.