JakeWharton / DiskLruCache

Java implementation of a Disk-based LRU cache which specifically targets Android compatibility.
http://jakewharton.github.io/DiskLruCache
Apache License 2.0
5.79k stars 1.18k forks source link

Uppercase Letters in keynames #71

Closed ndorigatti closed 10 years ago

ndorigatti commented 10 years ago

Hi Jake, i know the regex is clean ([a-z0-9-]{1,64}) but I'm wondering why don't accept uppercase letters. Since filenames accept them without any issue, why don't extend regex? [a-zA-Z0-9-]{1,64} would work for you? I was looking for a "no, because" but didn't find it... is there an explanation for the no-uppercases? I didn't receive the exception in logcat neither app crash, but could be due to some wrong copy/pasted code...

JakeWharton commented 10 years ago

Unfortunately some filesystems are case-insensitive by default which has the potential to cause collisions. If you need case sensitivity I recommend you hash the value (e.g., MD5) to achieve a unique but lowercase key. On Aug 31, 2014 4:31 PM, "Nicola Dorigatti" notifications@github.com wrote:

— Reply to this email directly or view it on GitHub https://github.com/JakeWharton/DiskLruCache/issues/71.