search

JakeWharton / RxBinding

RxJava binding APIs for Android's UI widgets.
Apache License 2.0
9.68k stars 971 forks source link

BottomNavigationView binding #298

Closed GSala closed 8 years ago

GSala commented 8 years ago

New in the Design Library in the Support Library revision 25.0.0. Should be fairly similar to the NavigationView already available.

https://developer.android.com/reference/android/support/design/widget/BottomNavigationView.html https://developer.android.com/reference/android/support/design/widget/NavigationView.html

JakeWharton commented 8 years ago

PR welcome. Busy for two weeks.

On Thu, Oct 20, 2016 at 5:21 AM GSala notifications@github.com wrote:

New in the Design Library in the Support Library revision 25.0.0. Should be fairly similar to the NavigationView already available.

https://developer.android.com/reference/android/support/design/widget/BottomNavigationView.html

https://developer.android.com/reference/android/support/design/widget/NavigationView.html

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JakeWharton/RxBinding/issues/298, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEW-resn1Hlg7okOVDezYFuJBMGY_ks5q1zJ_gaJpZM4Kb5j6 .

alex-townsend commented 8 years ago

I was already working on this -- can have the PR up later today most likely.

alex-townsend commented 8 years ago

Looks like there's a bug in the BottomNavigationView that crashes when adding a menu item programmatically (similarly to how it is done in RxNavigationViewTest). Filed a bug report (https://code.google.com/p/android/issues/detail?id=225731).

It works if I actually inflate the menu from XML, so I could do that for the test for now. Or wait to see what the comments are on the bug report. @JakeWharton thoughts? I was trying to keep it as close to what is there for NavigationView already.

JakeWharton commented 8 years ago

I assume you're referring to the test? I don't care if it's from XML or programmatically, so I would opt for whatever works for now. You can leave a TODO comment with a link to the bug to switch it back if you'd like.

On Thu, Oct 20, 2016 at 11:42 AM Alex Townsend notifications@github.com wrote:

Looks like there's a bug in the BottomNavigationView that crashes when adding a menu item programmatically (similarly to how it is done in RxNavigationViewTest). Filed a bug report ( https://code.google.com/p/android/issues/detail?id=225731).

It works if I actually inflate the menu from XML, so I could do that for the test for now. Or wait to see what the comments are on the bug report. @JakeWharton https://github.com/JakeWharton thoughts? I was trying to keep it as close to what is there for NavigationView already.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/JakeWharton/RxBinding/issues/298#issuecomment-255144028, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEacGqeVv8UYrpGToMQhq8Rv9qXh8ks5q14vQgaJpZM4Kb5j6 .

JakeWharton commented 8 years ago

Merged.