search

JakeWharton / RxBinding

RxJava binding APIs for Android's UI widgets.
Apache License 2.0
9.68k stars 971 forks source link

Use AutoValue for event classes? #361

Closed JakeWharton closed 7 years ago

JakeWharton commented 7 years ago

Does anyone have an opinion here? The disadvantage would be that it increases the method count. The advantage would be that it ensure correctness and uniformity of the equals/hashCode/toString impls.

dlew commented 7 years ago

It would all still proguard out fairly easily, right? In that case, I'm for it.

JakeWharton commented 7 years ago

Yes. It just turns one class into two.

On Sat, Feb 11, 2017 at 10:05 AM Daniel Lew notifications@github.com wrote:

It would all still proguard out fairly easily, right? In that case, I'm for it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JakeWharton/RxBinding/issues/361#issuecomment-279150145, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEYe1fdUnU6BFTpI_yc2Zh3VhB6HUks5rbc4_gaJpZM4L-GPa .