search

JakeWharton / RxBinding

RxJava binding APIs for Android's UI widgets.
Apache License 2.0
9.69k stars 971 forks source link

Private member access between outer and inner classes #379

Closed oldergod closed 7 years ago

oldergod commented 7 years ago

I noticed some inner classes' private members were access from the outer class. e.g. in RecyclerViewScrollEventObservable.java

If you would welcome a fix, I could send a PR as I am reading a lot of the code these days anyway.

JakeWharton commented 7 years ago

Sure

On Tue, May 9, 2017 at 3:56 AM Benoît Quenaudon notifications@github.com wrote:

I noticed some inner classes' private members were access from the outer class. e.g. in RecyclerViewScrollEventObservable.java https://github.com/JakeWharton/RxBinding/blob/master/rxbinding-recyclerview-v7/src/main/java/com/jakewharton/rxbinding2/support/v7/widget/RecyclerViewScrollEventObservable.java#L23

If you would welcome a fix, I could send a PR as I am reading a lot of the code these days anyway.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JakeWharton/RxBinding/issues/379, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEVvOc4Vac8umA8RdySaErH_M4Nqnks5r4BwlgaJpZM4NU8vB .